fix(middleware): keep handler 404 responses with Static HTML5 mode#2984
Closed
leno23 wants to merge 1 commit into
Closed
fix(middleware): keep handler 404 responses with Static HTML5 mode#2984leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
HTML5 fallback to index.html should apply only to router-level 404s, not to 404 errors returned by matched API handlers behind the static middleware. Fixes labstack#2775 Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Could you explain what use-case/issue this is solving? |
Contributor
|
Closing, this PR is against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
404(e.g. API resource not found)/api/test/3JSON 404 vs/client-routeSPA index fallbackTest plan
go test ./middleware/...TestStaticHTML5DoesNotOverrideHandler404Fixes #2775